Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E2e tests for lambdatest #37

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

E2e tests for lambdatest #37

wants to merge 5 commits into from

Conversation

rmccrear
Copy link
Contributor

This adds e2e test on LambdaTests for the test server at https://dev.zkemail.xyz

Set the env in your bash profile before running yarn test.

# bash profile
export LT_USERNAME="username"
export LT_ACCESS_KEY="yourkey"

cd into the e2e test directory install dependencies and run the tests remotely. (The tests run separately from the rest of the project, so they get their own package.json)

cd e2e-lambdatest
yarn
yarn test

Then, you can see the results on LambdaTest's web console. Two tests will run, the UI test and the ZKP test.

Unfortunately, the ZKP doesn't seem to work on LambdaTest servers. It is terminated before finishing. This might be a limitation of the remote testing service.

@Divide-By-0 Divide-By-0 mentioned this pull request Mar 8, 2023
Closed
@rmccrear
Copy link
Contributor Author

Also, added a new workflow in .circleci for forge tests in src/contracts

@Divide-By-0
Copy link
Member

Divide-By-0 commented Mar 31, 2023 •
edited
Loading

Thanks! I moved the forge tests to main. Let's keep the slower lambdatest tests here until we find a way to speed it up.

one nice thing about the benchmarks is that if you create a second .add(()=>{...}) clause in a benchmark it will run a second test on the same hardware at the same time to let you compare a new implementation with an old implementation. The custom automated reporting I wrote might have to change, but it will work fine when you click the button in the browser and will print averages and variances to the console.

@Divide-By-0
Copy link
Member

Can you try replacing the e2e lambdatest with circleci natively or browserstack or something else without the limit, and make those tests only run if all of the other tests pass first?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Divide-By-0 Divide-By-0 Awaiting requested review from Divide-By-0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rmccrear @Divide-By-0